Add <sys/timex.h> bindings for linux-musl #2333
Conversation
|
r? @JohnTitor (rust-highfive has picked a reviewer for you, use r? to override) |
dfoxfranke
force-pushed
the
master
branch
2 times, most recently
from
0650408 to
28f9ccc
Compare
|
AWS OSPO review, no OSPO concerns. |
| pub errcnt: ::c_long, | ||
| pub stbcnt: ::c_long, | ||
| pub tai: ::c_int, | ||
| pub __padding: [::c_int; 11], |
There was a problem hiding this comment.
A padding field doesn't need to be public generally, is there any reason?
There was a problem hiding this comment.
I suppose it doesn't matter much, but if this one should be private then I should've made the glibc ones private as well when I contributed #1642. So I can either keep this one public, be inconsistent, or make a breaking change to the glibc version. Up to you, I have no strong feelings on the matter.
There was a problem hiding this comment.
Ah makes sense! Let's keep it as-is for now.
|
@bors r+ |
|
📌 Commit 530b4ca has been approved by |
Add <sys/timex.h> bindings for linux-musl Adds bindings for `adjtimex()` & co. for linux-musl. Also adds `clock_adjtime()` to linux-glibc.
|
💔 Test failed - checks-actions |
|
Looks like a CI test is failing because http://ftp.debian.org/debian/dists/testing/main/installer-s390x/20200314/images/generic/initrd.debian has gone 404 (maybe releated to the release of Debian 11)? Obviously unrelated to this PR. |
|
Fixed on master, @bors retry |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Adds bindings for
adjtimex()& co. for linux-musl. Also addsclock_adjtime()to linux-glibc.