Move constants from linux/magic.h out of gnu and uclibc #2633
Conversation
These constants are provided by Linux, not libc.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
|
@bors r+ |
|
📌 Commit 50156f8 has been approved by |
Move constants from linux/magic.h out of gnu and uclibc These constants are provided by Linux (`linux/magic.h`), not libc. /cc `@kaniini`
|
💔 Test failed - checks-actions |
|
Why don’t you test musl targets on Alpine Linux (musl based distro) instead of Ubuntu (glibc based distro)? It would be much simpler and easier to troubleshoot. |
|
Alpine doesn't help in this case since we need a cross-toolchain for a different arch. If you look at ci/docker/mips-unknown-linux-musl/Dockerfile you will see that we are actually using a MIPS musl toolchain from openwrt for the specific CI builder that is failing. The kernel headers in that toolchain seem to predate binderfs support in the kernel. You could try updating the toolchain used in CI, which should resolve this failure. |
Update the mips-unknown-linux-musl CI toolchain to openwrt-sdk-21.02.1, as suggested [here]. This also switches from ar71xx to ath79, since [ar71xx is now deprecated] and ath79 is the replacement. [here]: rust-lang#2633 (comment) [ar71xx is now deprecated]: https://openwrt.org/docs/techref/targets/ar71xx
|
☔ The latest upstream changes (presumably #2639) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Superseded by #2639. |
These constants are provided by Linux (
linux/magic.h), not libc./cc @kaniini