Fix for https://github.com/rust-lang/libc/issues/2860 #2861
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
|
It seems that we are linking against symbols that have been changed in the latest CRT? Could we change libc to link against the new symbols instead? The UCRT must expose some version of printf, right? @rustbot ping windows |
|
cc @ChrisDenton |
|
Yeah. these aren't exported by the ucrt and haven't been for a long time. IIRC printf &co are implemented in the C headers as wrappers around internal functions. So I guess the options are:
|
|
2 & 3 are straight out: we don't want this kind of maintenance burden on libc. I think the best thing to do is to just link against @bors r+ |
Fix for #2860 This PR is intended to fix the issue #2860. As indicated in the issue, this fix requires linking against "legacy_stdio_definitions.lib", [which is only provided with Visual Studio >=15](https://docs.microsoft.com/en-us/cpp/porting/overview-of-potential-upgrade-issues-visual-cpp?view=msvc-170#libraries). I don't know how this could be checked conditionally at compile time though.
|
💔 Test failed - checks-actions |
|
Thanks for the review!
|
|
@bors retry |
Fix for #2860 This PR is intended to fix the issue #2860. As indicated in the issue, this fix requires linking against "legacy_stdio_definitions.lib", [which is only provided with Visual Studio >=15](https://docs.microsoft.com/en-us/cpp/porting/overview-of-potential-upgrade-issues-visual-cpp?view=msvc-170#libraries). I don't know how this could be checked conditionally at compile time though.
|
💥 Test timed out |
|
@bors retry |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
This PR is intended to fix #2860.
As indicated in the issue, this fix requires linking against "legacy_stdio_definitions.lib", which is only provided with Visual Studio >=15. I don't know how this could be checked conditionally at compile time though.