-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add missing getauxval for Linux uClibc targets #3738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
@JohnTitor the pull request has been removed from the merge queue due to some unrelated problems in the CI pipeline. Is there anything I can do to fix this? |
21d0b02
to
3940851
Compare
Sorry! It has been fixed now. |
(apply <rust-lang#3738> to `main`) (cherry picked from commit 3940851)
Hmm, I wonder what we should do for uclibc targets which do not include Of course, that's not the fault of this PR; I only raise it here because the audience might have some thoughts. One possibility: I could try to set up a OTOH I know we don't really want implementation in this crate. Not sure where an alternative spot would be, though. |
@skrap I've also had to deal with this. The problem is that Rust std can't be built without #[cfg(feature = "fake-getauxval")]
#[no_mangle]
extern "C" fn getauxval(_: c_ulong) -> c_ulong {
0
} But, as you suggested, detecting it in I think the question is if Rust std should really depend on this function or if it can detect that the function isn't available. The |
This should fix the following error when building Rust
std
on Linux uClibc targets.