Skip to content

Add Futex Constants FUTEX_WAITERS, FUTEX_OWNER_DIED and FUTEX_TID_MASK to Linux #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

danielschemmel
Copy link
Contributor

This PR adds three constants from linux/futex.h: FUTEX_WAITERS, FUTEX_OWNER_DIED and FUTEX_TID_MASK. These are related to how the kernel indicates certain events to the holders of priority-inheritance futexes (see man 2 futex).

I have intentionally typed those as u32, rather than ::c_int, as they are applied to the futex word (the target of the parameter uint32_t* uaddr).

@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you target main? We will cherry-pick to stable.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 12, 2024
@tgross35
Copy link
Contributor

@rustbot author

@danielschemmel danielschemmel changed the base branch from libc-0.2 to main August 12, 2024 22:32
@bors
Copy link
Contributor

bors commented Aug 12, 2024

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@tgross35
Copy link
Contributor

Thanks!

@tgross35 tgross35 enabled auto-merge August 12, 2024 22:33
@danielschemmel
Copy link
Contributor Author

@tgross35 Thank you for the review. The PR should now target main.

@tgross35 tgross35 added this pull request to the merge queue Aug 12, 2024
Merged via the queue into rust-lang:main with commit ee9fc6e Aug 13, 2024
39 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 13, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants