Skip to content

Added all additional ptrace options. #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2016
Merged

Conversation

valarauca
Copy link
Contributor

@valarauca valarauca commented Oct 5, 2016

Added additional PTrace Flags.

All the PTRACE_O are flags options values that are passed with PTRACE_OPTION.

The PTRACE_PEEKSIGINFO_SHARED is used for setting/fetching signal masks when interacting with thread groups not individual threads.

SYSEMU stuff I pulled from the kernel sources. As far as I can tell these flags haven't been added to <sys/ptrace.h>, which is weird because the two SYSEMU calls have been live on x64 since 2011. I'm starting a thread on kernel-newies about it.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@valarauca
Copy link
Contributor Author

Okay so Travis-CI is confirming the behavior I'm seeing on my local PC which is that <sys/ptrace.h> doesn't have the 2 SYSEMU flags populated in them.

I understand if you want to reject the patch on those grounds. I can rework it so only the option flags are being added. But the SYSEMU flags are the correct value.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Oct 5, 2016

📌 Commit 12e1cd1 has been approved by alexcrichton

bors added a commit that referenced this pull request Oct 5, 2016
Added all additional ptrace options.

Added additional PTrace Flags.

All the `PTRACE_O` are flags options values that are passed with `PTRACE_OPTION`.

The `PTRACE_PEEKSIGINFO_SHARED` is used for setting/fetching signal masks when interacting with thread groups not individual threads.

`SYSEMU` stuff I pulled from the kernel sources. As far as I can tell these flags haven't been added to `<sys/ptrace.h>`, which is weird because the two `SYSEMU` calls have been live on x64 since 2011. I'm starting a thread on kernel-newies about it.
@bors
Copy link
Contributor

bors commented Oct 5, 2016

⌛ Testing commit 12e1cd1 with merge 7c49396...

@bors
Copy link
Contributor

bors commented Oct 5, 2016

☀️ Test successful - status-appveyor, travis
Approved by: alexcrichton
Pushing 7c49396 to master...

@bors bors merged commit 12e1cd1 into rust-lang:master Oct 5, 2016
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants