Skip to content

musl: enable getrandom on all musl platforms #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Mar 20, 2025

Description

The existing bindings were added in #1399 and limited to targets where
rustc used musl version >= 1.1.20 which was not all musl targets at that
time. Since rust-lang/rust#107129 all musl
targets use musl 1.2.3. Hence, move the binding to the module root so it
is available for all musl targets.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

The existing bindings were added in rust-lang#1399 and limited to targets where
rustc used musl version >= 1.1.20 which was not all musl targets at that
time. Since rust-lang/rust#107129 all musl
targets use musl 1.2.3. Hence, move the binding to the module root so it
is available for all musl targets.
@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 22, 2025
@tgross35 tgross35 added this pull request to the merge queue Mar 22, 2025
Merged via the queue into rust-lang:main with commit 5c1e7ad Mar 22, 2025
43 checks passed
@tamird tamird deleted the musl-getrandom branch March 22, 2025 08:39
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
The existing bindings were added in rust-lang#1399 and limited to targets where
rustc used musl version >= 1.1.20 which was not all musl targets at that
time. Since rust-lang/rust#107129 all musl
targets use musl 1.2.3. Hence, move the binding to the module root so it
is available for all musl targets.

(backport <rust-lang#4346>)
(cherry picked from commit 77d3011)
@tgross35 tgross35 mentioned this pull request Apr 3, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-arm O-linux O-musl O-unix O-x86 S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants