Skip to content

Add missing signal related defines and fix dirent struct for VxWorks #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

Add missing signal related defines and fix dirent struct for VxWorks #4352

merged 2 commits into from
Apr 1, 2025

Conversation

hax0kartik
Copy link
Contributor

@hax0kartik hax0kartik commented Mar 25, 2025 •
edited
Loading

Description

Hi, this adds the missing signal-related defines and fixes the dirent struct, which was missing the d_type member.

Requesting stable nomination.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally on VxWorks

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35
tgross35 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @biabbas for reviewing.

Requesting stable nomination.

I've got it but FYI the labels can be added by anyone, with:

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Apr 1, 2025
@tgross35 tgross35 added this pull request to the merge queue Apr 1, 2025
Merged via the queue into rust-lang:main with commit 48aa1d7 Apr 1, 2025
43 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
@hax0kartik @tgross35
Add missing Signal related consts
02741e0 
(backport <rust-lang#4352>)
(cherry picked from commit c3dab47)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
@hax0kartik @tgross35
Add missing d_type member in dirent struct
5875016 
(backport <rust-lang#4352>)
(cherry picked from commit ba681b3)
@tgross35 tgross35 mentioned this pull request Apr 3, 2025
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

@biabbas biabbas biabbas approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hax0kartik @rustbot @tgross35 @biabbas