linux: gnu/musl: MAP_32BIT is only defined on x86#4511
Conversation
|
For mk68 and wasm-wali I'm okay to drop this immediately. I think we should give a warning to powerpc users though, could you mark this deprecated instead on that platform? If it's causing test failures, just add it as a skip in |
Even for the |
|
Yes please; that just makes things easier for the time being since the branches remain more in sync (read: fewer conflicts for me to resolve doing cherry picks), it will be easy to delete all deprecated items once we get closer to 1.0. |
077e84e to
6166e51
Compare
|
Should be done now, please double-check the deprecation message |
6166e51 to
00ef346
Compare
The Linux kernel only defines MAP_32BIT in the asm/mman.h header on x86. Remove the erraneous definitions for any other architectures on Linux targets. See https://github.com/torvalds/linux/blob/master/arch/x86/include/uapi/asm/mman.h#L5 This makes libc-test somewhat compile on powerpc64le musl. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
00ef346 to
9332d56
Compare
The Linux kernel only defines MAP_32BIT in the asm/mman.h header on x86. Remove the erraneous definitions for any other architectures on Linux targets. See https://github.com/torvalds/linux/blob/master/arch/x86/include/uapi/asm/mman.h#L5 This makes libc-test somewhat compile on powerpc64le musl. Signed-off-by: Jens Reidel <adrian@travitia.xyz> (backport <rust-lang#4511>) (cherry picked from commit 9332d56)
The Linux kernel only defines MAP_32BIT in the asm/mman.h header on x86. Remove the erraneous definitions for any other architectures on Linux targets. See https://github.com/torvalds/linux/blob/master/arch/x86/include/uapi/asm/mman.h#L5 This makes libc-test somewhat compile on powerpc64le musl. Signed-off-by: Jens Reidel <adrian@travitia.xyz> (backport <#4511>) (cherry picked from commit 9332d56)
Description
The Linux kernel only defines MAP_32BIT in the asm/mman.h header on x86. Remove the erraneous definitions for any other architectures on Linux targets.
This makes libc-test somewhat compile on powerpc64le musl (except semver, I'll follow up on that as well).
Sources
See https://github.com/torvalds/linux/blob/master/arch/x86/include/uapi/asm/mman.h#L5
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
^ didn't test the other two targets, but this is definitely correct. semver tests only tested for this on x86 already