musl: Switch to the new structure for socket.h #4539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuschaefer
reviewed
Aug 14, 2025
| @@ -0,0 +1,4 @@ | |||
| //! This directory maps to `include/uapi` in the Linux source tree. | |||
There was a problem hiding this comment.
Nice, such a comment is good to have
| @@ -0,0 +1,5 @@ | |||
| mod arch; | |||
There was a problem hiding this comment.
This could use a comment that mentions:
- this is musl-libc
- how it relates to the musl-libc source tree
There was a problem hiding this comment.
It has some much more detailed comments now
tgross35
force-pushed
the
libc-reorg-musl-socket
branch
2 times, most recently
from
3924af7 to
9fb182e
Compare
tgross35
force-pushed
the
libc-reorg-musl-socket
branch
3 times, most recently
from
bcb9805 to
f6b6a7d
Compare
Move `struct msghdr`, `struct cmsghdr`, `sendmmsg`, and `recvmmsg` over at this time, as well as two `SOCK_*` constants that were in the musl module. Link: https://github.com/kraj/musl/blob/9f204467e88c75e36105d1359951c5857c20fe0b/include/sys/socket.h
tgross35
force-pushed
the
libc-reorg-musl-socket
branch
from
f6b6a7d to
4cff0a6
Compare
tgross35
changed the title
socket.h
|
Thank you for taking a look @neuschaefer! I think at this point the basic structure is probably there enough to start actually moving things to these modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
struct msghdr,struct cmsghdr,sendmmsg, andrecvmmsgoverat this time, as well as two
SOCK_*constants that were in the muslmodule.
Link: https://github.com/kraj/musl/blob/9f204467e88c75e36105d1359951c5857c20fe0b/include/sys/socket.h