Open
Conversation
Functionality related to the Windows `time64_t` has been deprecated in favor of a single, 64-bit wide `time_t`. This has also required some work into getting rid of the conditional compilation uses of `time_t` on GNU target environments, and tweaking the `max_align_t` type, as that seemed to provide an incoherent interface in Windows with mingw32. During this work, what seems like some incoherences in the CI pipeline where found out, and have been addressed as well. This mostly consists of a step where mingw32 was being installed and possible "fixed" but that would never run because it relied on environment variables that were only visible in the runner once the job coming after the one setting up the Rust toolchain ran. This has now been removed in favor of not performing any checks, as CI logs seem to have been running for some time without this. The FIXME comment on the tier 1 platform support for Windows with GNU has also been removed as no segfaults were observed.
rustbot
added
A-CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Functionality related to the Windows
time64_thas been deprecated in favor of a single, 64-bit widetime_t. This has also required some work into getting rid of the conditional compilation uses oftime_ton GNU target environments, and tweaking themax_align_ttype, as that seemed to provide an incoherent interface in Windows with mingw32.During this work, what seems like some incoherences in the CI pipeline where found out, and have been addressed as well. This mostly consists of a step where mingw32 was being installed and possibly "fixed" but that would never run because it relied on environment variables that were only visible in the runner once the job coming after the one setting up the Rust toolchain ran. This has now been removed in favor of not performing any checks, as CI logs indicate this has been the case for some time.
The FIXME comment on the tier 1 platform support for Windows with GNU has also been removed as no segfaults were observed.
There's not yet an issue open specifically for deprecation of non-64-bit wide time and offset-related values, so the linked issue in the deprecation notice for
time64_tis still pending.Sources
max_align_thttps://github.com/mingw-w64/mingw-w64/blob/9b3dd0125792fe94d16cacdc596dbd42fca1b369/mingw-w64-headers/crt/stddef.h#L424-L427
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated