posix definitions should be used on Solaris #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility reasons, Solaris historically had its header files setup so that, unless specifically requested through specific header defines, either the old pre-POSIX interfaces or POSIX.1c Draft 6 interfaces were used. However, in the case of rust, since these symbols are linked directly instead of via system header files, the underlying posix symbol name can be used directly instead. These definitions should be corrected to match what they do on almost every other platform. Be aware this is a breaking change in terms of interface for any crates / consumers of these interfaces for Solaris. Fixes rust-lang#522
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 6740a8a has been approved by |
|
⌛ Testing commit 6740a8a with merge 7a3754f... |
bors
added a commit
that referenced
this pull request
Feb 16, 2017
posix definitions should be used on Solaris For compatibility reasons, Solaris historically had its header files setup so that, unless specifically requested through specific header defines, either the old pre-POSIX interfaces or POSIX.1c Draft 6 interfaces were used. However, in the case of rust, since these symbols are linked directly instead of via system header files, the underlying posix symbol name can be used directly instead. These definitions should be corrected to match what they do on almost every other platform. Be aware this is a breaking change in terms of interface for any crates / consumers of these interfaces for Solaris. Fixes #522
|
☀️ Test successful - status-appveyor, status-travis |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2017
…richton libstd needs update for pending libc change This updates libstd to accommodate the fixes made in rust-lang/libc#523 Fixes rust-lang#39868
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 17, 2017
…richton libstd needs update for pending libc change This updates libstd to accommodate the fixes made in rust-lang/libc#523 Fixes rust-lang#39868
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 17, 2017
…richton libstd needs update for pending libc change This updates libstd to accommodate the fixes made in rust-lang/libc#523 Fixes rust-lang#39868
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Feb 19, 2017
libstd needs update for pending libc change This updates libstd to accommodate the fixes made in rust-lang/libc#523 Fixes #39868
anatol
pushed a commit
to anatol/steed
that referenced
this pull request
Mar 31, 2017
libstd needs update for pending libc change This updates libstd to accommodate the fixes made in rust-lang/libc#523 Fixes #39868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility reasons, Solaris historically had its header files
setup so that, unless specifically requested through specific header
defines, either the old pre-POSIX interfaces or POSIX.1c Draft 6
interfaces were used. However, in the case of rust, since these symbols
are linked directly instead of via system header files, the underlying
posix symbol name can be used directly instead.
These definitions should be corrected to match what they do on almost
every other platform.
Be aware this is a breaking change in terms of interface for any crates
/ consumers of these interfaces for Solaris.
Fixes #522