struct addrinfo needs padding on Solaris/SPARC #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64-bit Solaris/SPARC has a 4-byte pad before ai_addrlen for historical reasons (ai_addrlen used to be defined as a size_t, which is 4 bytes in ILP32 and 8 in LP64, but was converted to a 4-byte socklen_t in Solaris 10, which necessitated padding for (more or less) binary compatibility).
|
@bors: r+ |
|
📌 Commit 1375070 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 7, 2017
struct addrinfo needs padding on Solaris/SPARC 64-bit Solaris/SPARC has a 4-byte pad before `ai_addrlen` for historical reasons (`ai_addrlen` used to be defined as a `size_t`, which is 4 bytes in ILP32 and 8 in LP64, but was converted to a 4-byte `socklen_t` in Solaris 10, which necessitated padding for (more or less) binary compatibility). See rust-lang/rust#43649.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
64-bit Solaris/SPARC has a 4-byte pad before
ai_addrlenfor historical reasons (ai_addrlenused to be defined as asize_t, which is 4 bytes in ILP32 and 8 in LP64, but was converted to a 4-bytesocklen_tin Solaris 10, which necessitated padding for (more or less) binary compatibility).See rust-lang/rust#43649.