-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Do not assume dynamic linking in musl/mips targets #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Required for rust-lang/rust#47663 |
Due to the usage of |
I think it will break... The target definition is initialized using |
Considering that we are not changing the default linking mode in rust-lang/rust#47663 anymore, can this be merged? |
@malbarbo hm I'm not sure I could say w/o testing, mind testing before and after this change to see if the targets build correctly? |
I had tested it with both static and dynamic linking. I tested it again after changing I had forgotten to commit the -fPIC changes, but I pushed it now. |
Ok! @bors: r+ |
📌 Commit 042b707 has been approved by |
Do not assume dynamic linking in musl/mips targets
☀️ Test successful - status-appveyor, status-travis |
No description provided.