This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Fix substract with borrow in FMA #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lokathor could you review this? This is resulting in |
|
This change looks reasonable at a glance. I know the test failures aren't part of this PR, but if you could fix them up that would be appreciated. I can have a proper look at things in about 10hrs from now. |
|
Pushed some changes |
jethrogb
commented
Jun 24, 2021
| @@ -218,6 +218,14 @@ mod tests { | |||
| -0.00000000000000022204460492503126, | |||
| ); | |||
|
|
|||
| assert_eq!(fma(-0.992, -0.992, -0.992), -0.00793599999988632,); | |||
| assert_eq!(fma(-0.992, -0.992, -0.992), -0.007936000000000007,); | |||
There was a problem hiding this comment.
This is the result from GNU libm
|
The following tests also fail on master:
Fixing these seems like a rabbit hole that I don't want to do. |
|
Oh boy. Yeah none of that is your fault, I thought it was just some extra warnings and stuff. |
Lokathor
approved these changes
Jun 25, 2021
tgross35
pushed a commit
that referenced
this pull request
Apr 18, 2025
Fix substract with borrow in FMA
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242
I assume there's a good reason we're not just using u128 math here.