Skip to content

mdbook should exit if serve can't serve #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshrotenberg opened this issue May 24, 2021 · 1 comment · Fixed by #1555
Closed

mdbook should exit if serve can't serve #1545

joshrotenberg opened this issue May 24, 2021 · 1 comment · Fixed by #1555

Comments

@joshrotenberg
Copy link
Contributor

If, for example, the address is already in use, an error is given but the tool doesn't exit:

❯ mdbook serve                                                                                                130 ↵
2021-05-24 13:23:22 [INFO] (mdbook::book): Book building has started
2021-05-24 13:23:22 [INFO] (mdbook::book): Running the html backend
2021-05-24 13:23:22 [INFO] (mdbook::cmd::serve): Serving on: http://localhost:3000
thread '<unnamed>' panicked at 'error binding to [::1]:3000: error creating server listener: Address already in use (os error 48)', /Users/joshrotenberg/.cargo/registry/src/github.1485827954.workers.dev-1ecc6299db9ec823/warp-0.2.5/src/server.rs:213:27
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2021-05-24 13:23:22 [INFO] (mdbook::cmd::watch): Listening for changes...
@joshrotenberg
Copy link
Contributor Author

Potentially related issues: #1472 and #1321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant