Skip to content

Play button should print something if there is no output. #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ehuss opened this issue Jul 4, 2021 · 0 comments · Fixed by #1599
Closed

Play button should print something if there is no output. #1594

ehuss opened this issue Jul 4, 2021 · 0 comments · Fixed by #1599
Labels
A-Playground Area: Playground E-Help-wanted Experience: Help Needed

Comments

@ehuss
Copy link
Contributor

ehuss commented Jul 4, 2021

When examples have a "Play" button, clicking it will say "Running...", and then nothing apparent to the user happens. Most examples don't actually emit any output. I'm wondering if it might be better, if there is no output from the example, to display some text to indicate it finished and that there is no output? I'm not sure how confusing this actually is for people, but it doesn't seem like a great user experience to me.
@ehuss ehuss added A-Playground Area: Playground E-Help-wanted Experience: Help Needed labels Jul 4, 2021
notriddle added a commit to notriddle/mdBook that referenced this issue Jul 7, 2021
@notriddle
feat(playground): show "No output" on playgrounds that print nothing
82d32ee 
Fixes rust-lang#1594
@notriddle notriddle mentioned this issue Jul 7, 2021
Merged
blandger pushed a commit to blandger/mdBook that referenced this issue Jul 11, 2021
@notriddle @blandger
feat(playground): show "No output" on playgrounds that print nothing
0a64073 
Fixes rust-lang#1594
notriddle added a commit to notriddle/mdBook that referenced this issue Dec 23, 2021
@notriddle
feat(playground): show "No output" on playgrounds that print nothing
cbd1b71 
Fixes rust-lang#1594
rubenmoor pushed a commit to rubenmoor/mdBook that referenced this issue Aug 5, 2022
@notriddle @rubenmoor
feat(playground): show "No output" on playgrounds that print nothing
8ca1671 
Fixes rust-lang#1594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Playground Area: Playground E-Help-wanted Experience: Help Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(playground): show "No output" on playgrounds that print nothing notriddle/mdBook
1 participant
@ehuss