Skip to content

Spacing in sidebar #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtolnay opened this issue Aug 28, 2016 · 4 comments
Closed

Spacing in sidebar #166

dtolnay opened this issue Aug 28, 2016 · 4 comments

Comments

@dtolnay
Copy link
Member

dtolnay commented Aug 28, 2016

selection_007

The chapters have a line height of 1.9em and the sections (and subsections) have a line height of 2.5em. This seems backward - I would expect chapters to be spaced at least as far apart as sections.

@azerupi
Copy link
Contributor

azerupi commented Aug 28, 2016

It would make more sense that way, indeed. I will look into it, thanks for reporting :)

@JIghtuse
Copy link
Contributor

JIghtuse commented Sep 3, 2016

@azerupi looks like it is enough to just swap these two line-heights to fix it. Will you accept this?
JIghtuse@4555adb

Before:
Before
After:
After

@azerupi
Copy link
Contributor

azerupi commented Sep 3, 2016

@JIghtuse of course I would gladly accept a PR :)

I have tried some values and I think 2.5em is a bit too much space for .chapter it looks weird. 1.9em for .section and 2.2em for .chapter looks better in my opinion. What do you think?

@JIghtuse
Copy link
Contributor

JIghtuse commented Sep 3, 2016

@azerupi yep, 2.2em for .chapter looks good for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants