Skip to content

mdbook init --title <title> fails to include title if git user name is not configured #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eureka-cpu opened this issue Nov 17, 2024 · 0 comments · Fixed by #2486
Closed
Labels
C-bug Category: A bug, incorrect or unintended behavior

Comments

@eureka-cpu
Copy link
Contributor

Problem

mdbook init --title <title> fails to include title if git user name is not configured

Steps

  1. inside some environment that doesn't have git user name configured
  2. mdbook init --title <title>
  3. cat book.toml, the title is not there
  4. do the above again after configuring git user name, the title is there now

Possible Solution(s)

Seems that there is a line in init.rs that only adds the config to the builder if the git user name is configured, even though it does a check before that for the title.

Notes

No response

Version

0.4.42
@eureka-cpu eureka-cpu added the C-bug Category: A bug, incorrect or unintended behavior label Nov 17, 2024
ehuss added a commit to eureka-cpu/mdBook that referenced this issue Nov 18, 2024
rik86189 pushed a commit to rik86189/mdBook that referenced this issue Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: A bug, incorrect or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant