Skip to content

Add tooltips to code buttons #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azerupi opened this issue Aug 3, 2017 · 7 comments · Fixed by #477
Closed

Add tooltips to code buttons #388

azerupi opened this issue Aug 3, 2017 · 7 comments · Fixed by #477
Labels
A-HTML Area: HTML Rendering C-enhancement Category: Enhancement or feature request E-Easy Experience: Easy

Comments

@azerupi
Copy link
Contributor

azerupi commented Aug 3, 2017

image

Buttons on code blocks do not currently have tooltips explaining what they do. It would be great to add tooltips with a very short explanation of what the buttons do (couple of words) when hovering over them.

@azerupi azerupi added A-HTML Area: HTML Rendering E-Easy Experience: Easy C-enhancement Category: Enhancement or feature request labels Aug 3, 2017
@budziq
Copy link
Contributor

budziq commented Aug 3, 2017

Also any other icon like print/hamburger/paint brush could use a tooltip

@budziq
Copy link
Contributor

budziq commented Aug 3, 2017

Ha I stand corrected, the print button already has a tooltip with the "title" attribute
We could easily implement the tooltips using the native browser tooltip like this

tooltip

<i class="fa fa-play play-button" title="Run the code"></i>

@azerupi
Copy link
Contributor Author

azerupi commented Aug 3, 2017

Yes :)
This is a really trivial addition. Good first issue for new contributors, if not too easy. :)

@budziq
Copy link
Contributor

budziq commented Aug 3, 2017

Well we might want to handle separately the expand/collapse code button so this issue would not be super trivial ;)

@azerupi
Copy link
Contributor Author

azerupi commented Aug 3, 2017

I guess trivial is relative, but by pointing out to new contributors that buttons are inserted in the page through JavaScript here. I am confident that anyone can pick up this issue without much difficulties. 😄

@budziq
Copy link
Contributor

budziq commented Aug 3, 2017

hmm we can even post TWIR. We met with great success in rust-cookbook when posting there :)

@projektir
Copy link
Contributor

With the work in #338, there is now a new reset button which should also have a tooltip:
f9wn5ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-HTML Area: HTML Rendering C-enhancement Category: Enhancement or feature request E-Easy Experience: Easy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants