add tooltip to icons #477
Merged
add tooltip to icons #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mockersf Very cool! Could you also add tooltips to the next and prev buttons at the bottom of the page? |
|
Oh, didn't see those as there are already tooltips for them in browser, they were only missing in mobile. |
|
|
|
Yes, the mobile-nav-chapters class is displayed instead of nav-chapters if screen is less than 1250px wide. Both sets of links should have the title now. |
|
Thanks @mockersf ! |
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
add tooltip to icons and previous/next chapter links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #388
added titles to play/copy/reset, expand/collapse and sidebar/theme buttons