use macros from the log crate, issue #151 #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,7 +42,7 @@ impl MDBook { | |||
| pub fn new(root: &Path) -> MDBook { | |||
|
|
|||
| if !root.exists() || !root.is_dir() { | |||
| output!("{:?} No directory with that name", root); | |||
| info!("{:?} No directory with that name", root); | |||
There was a problem hiding this comment.
This one could be changed to warn
|
Thanks for doing this! One thing that is missing is the actual logger in the binary. We could use env_logger/ (I'm not familiar with any others). You would have to add env_logger to the dependencies and only import it in the binary ( Once you have done that it looks good enough to merge :) |
added 2 commits
August 14, 2016 14:40
|
Looks good, thanks! 👍 |
|
It was pretty small, but thanks for the instructions. Good experience for the beginner like me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't too hard :)
Please comment if there is more to it.