Fix clippy warnings #2014
Closed
Fix clippy warnings #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `clippy::uninlined_format_args`
ehuss
reviewed
Feb 9, 2023
src/book/book.rs
Outdated
| pub struct Book { | ||
| /// The sections in this book. | ||
| pub sections: Vec<BookItem>, | ||
| __non_exhaustive: (), |
There was a problem hiding this comment.
This is a breaking change, can you revert it please?
There was a problem hiding this comment.
Isn't the added #[non_exhaustive] attribute the same as the private field?
There was a problem hiding this comment.
No, it is exposed to preprocessors. There was a similar attempt earlier which was reverted: #1848
There was a problem hiding this comment.
I removed the change.
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Closing as I have applied some clippy fixes in #2083. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.