refactor: Remove store.js (use localStorage) #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this in:
|
Merged
|
One of the tests references |
|
It looks like there are merge conflicts in |
|
@Michael-F-Bryan, yes, just did 👍 |
|
I think this may have broken themes the first time you load a book because local storage is handled differently. Once you change the theme local storage will be updated and you'll never see the missing styles again. I've created an issue for this, #573. |
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't cause any issues with the browsers listed in RFC 1985. The only gotcha is Safari, where
localStoragemethods throw errors in Incognito Mode (this will fail gracefully, but the changes won't be saved - I would say this is not an issue since it is Incognito Mode after all).Closes #548.