Skip to content

Stop pulling pulldown-cmark from master #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Michael-F-Bryan
Copy link
Contributor

This removes the need for a [patch] in Cargo.toml. We originally needed it because I was using PartialEq (implemented in pulldown-cmark/pulldown-cmark#118) in the summary parser and because they haven't (yet) made another release we were pulling directly from master.

I've added in a couple *_eq() replacements, with FIXME comments so we know to remove them at a later date.

This means we can now make another release!

@Michael-F-Bryan Michael-F-Bryan merged commit fa84da0 into rust-lang:master Jan 18, 2018
@Michael-F-Bryan Michael-F-Bryan deleted the pulldown_cmark-patch branch January 22, 2018 05:52
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
* Manually implemented PartialEq for pulldown_cmark types

* Fixed an issue where we wouldn't skip a tag properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant