-
Notifications
You must be signed in to change notification settings - Fork 1.7k
WIP: Add support for virtual chapters #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
672e102
Add variant 'VirtualChapter' to 'BookItem'
teiesti bae55fb
Add variant 'VirtualLink' to 'SummaryItem'
teiesti 598c8e3
Reduce technical depts
teiesti 7397e63
Extend load_summary_item() in order to support virtual chapters
teiesti bcab4e2
Remove unnecessary field 'content' in 'VirtualChapter'
teiesti 95995cb
Remove resolved open question
teiesti 6205658
Implement parsing '- [Some virtual chapter]()' as 'VirtualLink'
teiesti cac7b06
Adapt basic tests for 'SummaryParser'
teiesti 3c25b3f
Fix example in the documentation
teiesti c9605a0
Fix 1640e5990bb36b187a9f31590546347f249d3343
teiesti 4a3d994
Rename parse_item() to parse_linklike()
teiesti ed8fd38
Add variant __NonExhaustive to BookItem
teiesti 40b98d6
remove unused import
azerupi 9e5d5bb
fix missing parameters
azerupi 82197b7
Make virtual chapters work with the renderer
azerupi ee45e5f
fix test missing enum variant
azerupi a5e7421
Generate empty index.html when first chapter is virtual
azerupi 3990398
Fix bug where sub_items of virtual chapters were not visited
azerupi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're making breaking changes, it may be a good idea to add a variant:
to ensure client libraries can handle new enum variants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I will do that!