-
Notifications
You must be signed in to change notification settings - Fork 1.7k
WIP on ePub #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP on ePub #94
Conversation
@@ -38,7 +38,7 @@ impl MDBook { | |||
.set_src(&root.join("src")) | |||
.set_dest(&root.join("book")) | |||
.to_owned(), | |||
renderer: Box::new(HtmlHandlebars::new()), | |||
renderer: Box::new(Pandoc::new()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just temporary to make local testing easier, but curious how we see this playing out long term. Should the mdbook command line support a new argument? Default to using all the available renderers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the long term I guess it would be nice if the user could choose a couple of formats in his book.json
and on build all formats would be exported. This needs a little bit of thinking to come up with a good design:
- How to handle the automatic switching of renderers
- Where to export, currently the html version is exported in
book
dir but where would pdf, epub, ... go?
Not often, but if we agree on some date / time I can come online ;)
That would be awesome! I have been wanting to rewrite how mdBook works internally so that it would be easier to implement / enable / disable different renderers, themes and plug-ins for extra functionality. Because currently you can only have one renderer and this rendererer is not completely isolated into its own module to just swap it out. I have experimented with some designs but didn't get far. The problem is that I feel like it would be a shame to put a lot of effort in writing the EPUB / PDF / MOBI renderer now and have to rewrite it when that new API is implemented. On the other hand I don't want to block new features as I have nothing concrete yet and it will probably take more time than I expect. Maybe we could work together on that rewrite, we could discuss ideas about the new API. You could concentrate more on implementing the renderer and I could get useful feedback about how bad my ideas are. 😉 It will probably take more time, but I think it could be beneficial in the end and I would feel less guilty of making you do unnecessary work! Now that you know that, I leave the choice up to you. Don't feel obligated in any way! :) |
I am going to close this, as it has been inactive for some time |
I think a minimal useful version of this would:
MDBook
and concat them