Skip to content

avoid unnecessary RefCell calls #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2021
Merged

avoid unnecessary RefCell calls #1814

merged 6 commits into from
May 23, 2021

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 23, 2021

@RalfJung
Copy link
Member Author

Ah, there's (at least) one problem... the allocations created by handle_miri_resolve_frame are marked as immutable but are returned at Box type -- and, somehow, that was not a problem so far, but now it is becoming a problem.

@RalfJung RalfJung changed the title Rustup avoid unnecessary RefCell calls May 23, 2021
@RalfJung RalfJung added the S-blocked-on-rust Status: Blocked on landing a Rust PR label May 23, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2021
fix deallocation of immutable allocations

As part of rust-lang/miri#1814, I realized that we currently allow deallocating immutable allocations. This PR fixes that, and also adds some new APIs that are required to still support the existing Miri backtrace support.

r? `@oli-obk`
@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented May 23, 2021

📌 Commit a03f700 has been approved by RalfJung

@bors
Copy link
Contributor

bors commented May 23, 2021

⌛ Testing commit a03f700 with merge 62046bf...

@bors
Copy link
Contributor

bors commented May 23, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 62046bf to master...

@bors bors merged commit 62046bf into rust-lang:master May 23, 2021
@RalfJung RalfJung deleted the rustup branch May 23, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked-on-rust Status: Blocked on landing a Rust PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants