Factor current-span logic into a caching handle #2139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saethlin
force-pushed
the
lazy-current-span
branch
from
4b49702 to
6e0e612
Compare
RalfJung
reviewed
May 22, 2022
RalfJung
reviewed
May 22, 2022
RalfJung
reviewed
May 22, 2022
saethlin
force-pushed
the
lazy-current-span
branch
from
6e0e612 to
b20c6cf
Compare
Member
|
Nice! |
Contributor
|
📌 Commit b20c6cf has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This was referenced May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #2030 and while working on #1935 it became quite clear that we need to do some caching here, because some retag operations generate many calls to
log_invalidation, and would thus search the current thread's stack many times for a local crate. This caching fixes that. This handle type also has the nice benefit of tucking away all theThreadManager+CrateNumlogic.