Miri subtree sync #2550
Closed
Miri subtree sync #2550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saethlin
reviewed
Sep 19, 2022
| Every time: | ||
|
|
||
| ``` | ||
| ulimit -s 60000 |
There was a problem hiding this comment.
Why do we need to change the stack size to run this?
There was a problem hiding this comment.
because the script will segfault bash otherwise 😫 See also rust-lang/rust-clippy#5565 where all of this was figured out
There was a problem hiding this comment.
Can't the script do this itself?
There was a problem hiding this comment.
I didn't want to modify it ^^
RalfJung
reviewed
Sep 20, 2022
|
|
||
| ``` | ||
| ulimit -s 60000 | ||
| src/tools/miri/git-subtree.sh push --prefix src/tools/miri/ miri-your-fork miri-subtree-sync |
There was a problem hiding this comment.
Needs to be updated since the script was removed
(also IMO the script should be in src/tools somewhere outside miri since it is just as useful for clippy)
There was a problem hiding this comment.
Yea, I'll put it in src/etc when the license stuff is clear
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out the very first subtree sync