aarch64: add shims for pairwise widening/wrapping addition#4912
Conversation
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
|
|
||
| // Use wrapping addition on u128 to simulate | ||
| // widening addition for the destination type. | ||
| let sum = a_val.wrapping_add(b_val); |
There was a problem hiding this comment.
Shouldn't this be strict_add? An overflow would lose data which sounds bad. (Probably also applies above.)
There was a problem hiding this comment.
I don't think it matters because it's widening. I'll change it though
|
@rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
f9cd75e to
0c36d8a
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
This looks great, thanks! Please squash the commits. You can squash manually if there are multiple independent commits you want to preserve, or use @rustbot author |
9327d7c to
0fed718
Compare
Combined with #4899 this is sufficient to run the zlib-rs crc32 tests.
With LLVM 23 I believe that these implementations should no longer be needed because the
stdarchimplementation can use portable intrinsics. Until then, we do need them, and the test coverage is nice regardless.