This repository was archived by the owner on Sep 30, 2020. It is now read-only.
Build on s3 #149
Closed
Build on s3 #149
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the site is moving off of github pages, it would be better to use conventional branch naming. Doing this as a merge commit because I doubt github would handle a PR of branch renaming gracefully, and we want to keep the github-pages site operational during the transition.
See https://travis-ci.org/edunham/rust-www/builds/67560526 and http://www-rust-lang-org.s3-website-us-west-1.amazonaws.com/ for an example of it successfully working. That was built specifying `edunham/rust-www`, whereas the file now specifies `rust-lang/rust-www` because we want to automate builds after this PR lands.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Going to rebase and make a new PR since master is now up to date with gh-pages. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #148 .
Sorry about the gnarly PR; a vast majority of it is simply to bring the master branch of this repo up to date with the gh-pages branch.
The only new commits are a5ced88 (adding
.travis.ymlto upload rendered site into S3 bucket) and 97b1674 (add custom error page).My rationale behind merging into master is that I'd like to leave the github-pages site totally untouched until I've verified that everything about the S3 copy is integrated correctly.
Before merging, could someone with permissions on this repo please flip the Travis switch at https://travis-ci.org/profile/rust-lang to green?