Skip to content

Fix CI more#112

Merged
BoxyUwU merged 2 commits intorust-lang:masterfrom
popzxc:popzxc-fix-ci-even-more
May 4, 2026
Merged

Fix CI more#112
BoxyUwU merged 2 commits intorust-lang:masterfrom
popzxc:popzxc-fix-ci-even-more

Conversation

@popzxc
Copy link
Copy Markdown
Contributor

@popzxc popzxc commented May 1, 2026

@BoxyUwU OK, this time it should work. I've changed the action to a more modern one, and tested it in my fork (it deployed).

As a bonus, mdbook will be built on PR too.

One caveat: you should go to the repo settings, and in GitHub Pages switch "Source" to "GitHub Actions" for deployments to work.

image

@popzxc popzxc closed this May 1, 2026
@popzxc popzxc reopened this May 1, 2026
@popzxc
Copy link
Copy Markdown
Contributor Author

popzxc commented May 1, 2026

@BoxyUwU will ping in a comment as well just in case, not sure if pings come through from the message edits.

Comment thread .github/workflows/deploy_mdbook.yml Outdated
Comment thread .github/workflows/deploy_mdbook.yml Outdated
Comment thread .github/workflows/deploy_mdbook.yml Outdated
Comment thread .github/workflows/deploy_mdbook.yml Outdated
Copy link
Copy Markdown

@ubiratansoares ubiratansoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Added some comments. I can change the Github repo settings and move GH pages deployment source to Github Actions as soon as this PR is ready merge.

Let me know if you have any other questions

@popzxc
Copy link
Copy Markdown
Contributor Author

popzxc commented May 4, 2026

@ubiratansoares -- heya, done.

@BoxyUwU BoxyUwU merged commit ba1ad9b into rust-lang:master May 4, 2026
2 checks passed
@popzxc popzxc deleted the popzxc-fix-ci-even-more branch May 5, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants