Skip to content

Add new temporary lifetime extension rule #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add new temporary lifetime extension rule #1813

wants to merge 7 commits into from
+7 −5

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented May 7, 2025

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label May 7, 2025
@m-ou-se
Copy link
Member Author

m-ou-se commented May 7, 2025

@WaffleLapkin I vaguely remember you were working on rewriting this section at some point? Maybe I misremember.

@m-ou-se m-ou-se mentioned this pull request May 7, 2025
Open
@WaffleLapkin
Copy link
Member

I indeed found this message:

[14:11] waffle: thank uuu!! with this knowledge I can document this stuff in the compiler and reference >:3

I did forget about it and can't find any changes I did back then, so I'd assume I haven't even started rewriting it. I'll write this down so I don't forget again ^^'

WaffleLapkin
WaffleLapkin reviewed May 7, 2025
View reviewed changes
@joshtriplett
Copy link
Member

This looks correct to me.

traviscross
traviscross reviewed May 8, 2025
View reviewed changes
traviscross
traviscross reviewed May 8, 2025
View reviewed changes
ehuss
ehuss reviewed May 8, 2025
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the examples below still need updating (just below in the "Examples" section).

@ehuss ehuss added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: The marked PR is awaiting review from a maintainer labels May 8, 2025
@m-ou-se
Copy link
Member Author

m-ou-se commented Jun 13, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: The marked PR is awaiting review from a maintainer and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Jun 13, 2025
@m-ou-se
Copy link
Member Author

m-ou-se commented Jun 13, 2025

This now fails the code tests because rust-lang/rust#140593 (which this PR is trying to document) isn't merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

@traviscross traviscross traviscross left review comments

@WaffleLapkin WaffleLapkin WaffleLapkin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
S-waiting-on-review Status: The marked PR is awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@m-ou-se @WaffleLapkin @joshtriplett @ehuss @traviscross @rustbot