Skip to content

automata: check for overflow in Span::offset #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tautschnig wants to merge 2 commits into
base: master
Choose a base branch
from
Open

automata: check for overflow in Span::offset #1380

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0944b78
automata: check for overflow in Span::offset
tautschnig Aug 3, 2026
e8b164b
automata: overflow-specific panic messages and a regression test for …
tautschnig Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion regex-automata/src/util/search.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,9 +843,20 @@ impl Span {

/// Returns a new span with `offset` added to this span's `start` and `end`
/// values.
///
/// # Panics
///
/// This panics if adding `offset` to either part of this `Span` would
/// result in overflow.
#[inline]
pub fn offset(&self, offset: usize) -> Span {
Span { start: self.start + offset, end: self.end + offset }
Span {
Comment on lines 852 to +853
start: self
.start
.checked_add(offset)
.expect("invalid start+offset"),
end: self.end.checked_add(offset).expect("invalid end+offset"),
}
}
}

Expand Down