Repository navigation
fix(syntax): allow Parser to be reused - #1394
Open
jaideeppyne wants to merge 1 commit into
Open
jaideeppyne wants to merge 1 commit into
jaideeppyne wants to merge 1 commit into
Conversation
reset() ran after an assertion that offset was still 0, so a second parse always panicked. Reset first, and also clear capture index, capture names, and scratch so reuse starts from a clean parser. Fixes rust-lang#1392
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`Parser::parse` panicked on the second call because `parse_with_comments` asserted `offset == 0` before calling `reset()`.
Reset first, and also clear `capture_index`, `capture_names`, and `scratch` so a reused parser does not leak capture numbering or names from the previous pattern.
Fixes #1392