Skip to content

Markdown style link for mdbook #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2017
Merged

Markdown style link for mdbook #2199

merged 4 commits into from
Dec 6, 2017

Conversation

ordovicia
Copy link
Contributor

Raw URL strings (e.g. https://example.com) are not recognized as links in published mdbook.
So this PR converts them into Markdown style (e.g. [link](https://example.com)).

@steveklabnik
Copy link
Member

You could also use <http://whatever.com>, which is a bit shorter. I guess you've already done the work...

@ordovicia
Copy link
Contributor Author

Ah I did not know that. Thank you for telling me.
Actually I did this work with a short script, so it was not a hard job.

Also, in some RFCs links were written in [link](https://example.com) style originally, and I think it's better to unify styles.

@ordovicia ordovicia changed the title Markdown link Markdown style link for mdbook Nov 10, 2017
@Centril
Copy link
Contributor

Centril commented Dec 6, 2017

Thanks! Merging for now - we can always change to the other format later.

@Centril Centril merged commit 8ee535b into rust-lang:master Dec 6, 2017
aturon added a commit that referenced this pull request Feb 23, 2018
Markdown style link for mdbook (same as #2199)
@Centril Centril added the not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants