This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Move vfs-racer impls to RLS #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way, we don't need to maintain racer version in VFS.
This was referenced Jul 27, 2018
Closed
|
I'm for this PR. |
|
Thanks! |
Xanewok
reviewed
Jul 29, 2018
| @@ -321,7 +323,7 @@ impl RequestAction for Completion { | |||
| let vfs = ctx.vfs; | |||
| let file_path = parse_file_path!(¶ms.text_document.uri, "complete")?; | |||
|
|
|||
| let cache = racer::FileCache::new(vfs); | |||
| let cache = racer_cache(vfs); | |||
There was a problem hiding this comment.
I realize this is minor and a thing of preference, but personally I'd find it a lot easier to read with racer::FileCache::new(RacerVfs(vfs)) as this limits what I'd expect to need to know - here it'd just be a impl racer::FileLoader for RacerVfs/*(Arc<Vfs>)*/ that is hiding somewhere 😉
Super minor though!
|
I just wanted to ping you @nrc bit it seems you were faster! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way, we don't need to maintain racer version in VFS.
Right now, for example, I can't say
racer = { path = "../racer" }inrls/Cargo.toml, b/c that won't be the same racer that rls_vfs usues. But given that the amount of code in question is tiny, it seems operationally more effective to just write a newtype wrapper inside rls.