Methods' parameters snippet includes self

[Avishayy]

#3432 introduced snippet support for functions parameters, however - it includes the self parameter when it shouldn't, e.g.

impl Rectangle {
    fn translate(&mut self, x: f64, y: f64) { ... }
}

fn main() {
    let mut rectangle = Rectangle { ... };
    rectangle.translate| // press completion hotkey
}

Picking the completion will expand to (&mut self, x, y) when the expected behaviour is (x, y)

One more interesting thing is that requesting completions with Rectangle:: will produce no results as module functions with the self parameter will not receive completions.

I will take care of the first issue but I don't understand the rationale in the second one, is there supposed to be something else there or was it just not implemented yet?

[Avishayy]

Nevermind, seems like this was fixed in #3442 and I found out when I tried to rebase on master and had conflicts :)