Skip to content

Skip self param when completing methods #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

Skip self param when completing methods #3442

merged 1 commit into from
Mar 4, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Mar 4, 2020

bors r+
🤖

@bors
Copy link
Contributor

bors bot commented Mar 4, 2020

Build succeeded

@bors bors bot merged commit 94189d0 into rust-lang:master Mar 4, 2020
@flodiebold
Copy link
Member

Ideally, we shouldn't skip it if I write S::foo instead though 🤔

@matklad matklad deleted the skip-self branch March 4, 2020 14:39
@Avishayy Avishayy mentioned this pull request Mar 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matklad @flodiebold