Skip to content

internal: Rollback env vars changed by a proc macro #11356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2022

Conversation

vlad20012
Copy link
Member

Fixes #11355

@vlad20012 vlad20012 force-pushed the proc-macro-env-rollback branch from 19ae5aa to c5db902 Compare January 27, 2022 18:49
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors d+

@bors
Copy link
Contributor

bors bot commented Jan 28, 2022

✌️ vlad20012 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@vlad20012 vlad20012 force-pushed the proc-macro-env-rollback branch from c5db902 to e93386f Compare January 28, 2022 10:43
@vlad20012
Copy link
Member Author

I had some discussion with @bjorn3 in issue #11355. Shouldn't we wait for his comments on this?

@vlad20012
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 30, 2022

@bors bors bot merged commit 6010431 into rust-lang:master Jan 30, 2022
@lnicola lnicola changed the title Rollback env vars changed by a proc macro internal: Rollback env vars changed by a proc macro Jan 30, 2022
bors bot added a commit to intellij-rust/intellij-rust that referenced this pull request Jan 31, 2022
8489: Update `ra_ap_proc_macro_srv` to `0.0.94`, fix disk usage, fix pwd r=vlad20012 a=vlad20012

This update consists of rust-lang/rust-analyzer#11365, rust-lang/rust-analyzer#11353 and rust-lang/rust-analyzer#11356 PRs

Fixes #7709
Fixes #8238 in a proper way (#8271 was a hacky hotfix)

changelog: Don't fill up disk space by proc macro DLLs on Windows

Co-authored-by: vlad20012 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Env vars set by proc macros should be cleared after a macro expansion
2 participants