Skip to content

Better error message on Flycheck Error message #11891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2022
Merged

Better error message on Flycheck Error message #11891

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
635270d
Better error message hinting about `cargo clippy`
flipbit03 Apr 3, 2022
8e5c57f
wordsmithing.
flipbit03 Apr 3, 2022
ca9718a
Made error output the contents of Cargo's stderr as well.
flipbit03 Apr 4, 2022
84cf6ad
Using `error` instead of `output.stderr` in failure mode.
flipbit03 Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/flycheck/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,8 @@ impl CargoActor {
Ok(output) if output.status.success() => Ok(()),
Ok(output) => {
Err(io::Error::new(io::ErrorKind::Other, format!(
"Cargo watcher failed, the command produced no valid metadata (exit code: {:?})",
output.status
"Cargo watcher failed, the command produced no valid metadata (exit code: {:?})\nCargo's stderr output:\n{}",
output.status, error
)))
}
Err(e) => Err(io::Error::new(e.kind(), format!("{:?}: {}", e, error))),
Expand Down