fix: consider relative offset to fake ident token in expansion for completion#14043
Merged
bors merged 2 commits intorust-lang:masterfrom Feb 5, 2023
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
Author
|
We need a proc macro that changes the length of a token and keeps its span to write a test for this. Is it worth adding another in-memory proc macro for tests? (I did test manually and confirmed the original issue resolves with this patch.) |
Member
|
Adding a proc-macro for this sounds good, proc-macros swapping out tokens/modifying tokens sounds like a good thing to have for tests |
Contributor
|
✌️ @lowr can now approve this pull request |
lowr
added
S-waiting-on-author
lowr
force-pushed
the
fix/completion-within-str-that-changed
branch
from
dcffbd4 to
a4d0b5c
Compare
Contributor
Author
|
Rebased, added a super contrived proc macro for test and 2 tests that would cause panic without this PR. @bors r=Veykril |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13836
When we check if the offset of fake ident token is out of bounds in the "actual expansion" (i.e. expansion without the fake ident token), we should take relative offset to it into account to match how we'd get token after expansion.