Support computing layout of RPIT #14087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? @Veykril This is not a deep change in the type system. It just changes a |
Veykril
approved these changes
Feb 6, 2023
|
@bors r+ |
flodiebold
reviewed
Feb 6, 2023
Comment on lines
+51
to
+57
| let mut cmd = std::process::Command::new("rustc"); | ||
| cmd.args(["-Z", "unstable-options", "--print", "target-spec-json"]).env("RUSTC_BOOTSTRAP", "1"); | ||
| let output = cmd.output().unwrap(); | ||
| assert!(output.status.success(), "{}", output.status); | ||
| let stdout = String::from_utf8(output.stdout).unwrap(); | ||
| let target_data_layout = | ||
| stdout.split_once(r#""data-layout": ""#).unwrap().1.split_once('"').unwrap().0.to_owned(); |
There was a problem hiding this comment.
can you extract that to a function?
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Feb 6, 2023
Reuse fetching target data layout from rustc function fix #14087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And some refactoring to make code more type safe.