Conversation
rustbot
added
the
S-waiting-on-review
jsoref
left a comment
jsoref
left a comment
There was a problem hiding this comment.
Most spelling corrections automatically suggested by Google Sheets (when being run on the rust repository). I've manually transplanted these commits into this repository.
All fault mine.
| // and "parent" is the parent of the original expression... | ||
| // | ||
| // For this we utilize mutable mutable trees, which is a HACK, but it works. | ||
| // For this we utilize mutable trees, which is a HACK, but it works. |
There was a problem hiding this comment.
sometimes doubled words have meaning, I'm hoping this isn't one of those cases...
There was a problem hiding this comment.
Well, we have mutable immutable trees, so I'm not sure here 😄.
|
One commit per spelling fix seems a bit excessive if you ask me 😅 |
|
LGTM, but I'll have to take a closer look, probably tomorrow. |
|
I'm happy to squash or let someone else do it. The individual commits make it easier for me to drop/correct individual changes and rebase. |
lnicola
left a comment
lnicola
left a comment
There was a problem hiding this comment.
Would you mind squashing and maybe fixing that nit (builtin)?
* a rule * access * after * amount * annotations * assignment * assist * associated * attribute * borrowed * built-in type * clarification * command * const * constructor * corresponding * counterparts * curlies * dependencies * deterministic * diagnostic * duplicates * edge * edited * efficient * elsewhere * execution * expression * extensions * extracted * fill * github * helper * heuristic * incomplete * indent end * inlay * invocation * lifetime * looking * maybe * move * mutability * mutable * necessarily * necessary * negative * nonexistent * occurred * offsets * offsetted * overridden * parameters * params * params_and_where_preds_in_scope * paredit * parent * parentheses * prepended if * punctuation * receive * receiver * referring * repeated * representing * semantically * separately * shouldnot * siblings * similar * something's * statement * struct * structure * surprise * the * this * transparent * unimplemented * unnamed * unnecessary * unneeded * unreachable * unterminated * utilities * variant * variants * visibility * work around (v) * workaround Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
|
@lnicola applied and squashed, and thanks again for fixing the tests -- and thanks to |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
changelog internal (first contribution) fix all spelling mistakes |
| Additionally nothing handles deleting releases which we need for our rolling | ||
| `dev` release. | ||
|
|
||
| To handle all this this action rolls-its-own implementation using the |
There was a problem hiding this comment.
This sentence was correct before and sounds broken now. It needs to have "this" two times, one for the phrase, and one as an adjective of the subject. However, it probably should have had a comma before between them.
6 participants
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/rust-analyzer/actions/runs/4699991040#summary-12751355796
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/rust-analyzer/actions/runs/4699991284#summary-12751356293
closes #14567