Skip to content

fix: Deduplicate passed workspaces by top level cargo workspace they belong to #14603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Apr 18, 2023

Fixes #14571

With this we should be supporting vscode workspaces properly

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2023
@Veykril
Copy link
Member Author

Veykril commented Apr 18, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 18, 2023

📌 Commit 9c40897 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 18, 2023

⌛ Testing commit 9c40897 with merge e84781a...

@bors
Copy link
Contributor

bors commented Apr 18, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e84781a to master...

@bors bors merged commit e84781a into rust-lang:master Apr 18, 2023
@Veykril Veykril deleted the workspaces branch April 18, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode workspaces don't play nicely with r-a
3 participants