internal: Add minicore smoke test#14604
Conversation
rustbot
added
the
S-waiting-on-review
crates/ide-diagnostics/src/tests.rs
Outdated
| #[test] | ||
| fn minicore_smoke_test() { | ||
| // Checks that there is no diagnostic in minicore for each flag. | ||
| for flag in MiniCore::available_flags() { |
There was a problem hiding this comment.
Given flags can be nested to activate things only when multiple are active this doesn't make too much sense. I think it's fine to just check with all flags enabled.
There was a problem hiding this comment.
In this way it can catch missing dependencies between flags, which happened for me one time IIRC. But yes it seems it doesn't cover some cases. Is it fine to check one time for each flag and one time with all flags enabled? A complete check should try every 2^n subset of flags, which is definitely not worth it.
There was a problem hiding this comment.
I implemented the "one time for each flag and one time with all flags" approach.
There was a problem hiding this comment.
Doing both seems fine as well 👍
|
@bors r+ |
|
☀️ Test successful - checks-actions |
4 participants
fix #14501