fix: Add enum, reference, array and slice to render_const_scalar
#14947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Member
Author
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
lnicola
changed the title
render_const_scalarrender_const_scalar
Member
|
This either completely fixed or broke const eval 😄
|
Member
Author
|
A drop was expected, since unsupported rendering was reported as eval fail. But now that all are zero is a bit suspicious :) I hope this is just due simple usages of const eval in these projects, and not due this PR breaking metrics. The const eval itself is still not on par with rustc, missing standard library dependencies, missing features in mir, type mismatches and unresolved functions and any other r-a problem can bring const eval down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.