internal: Only compare relevant parts in ide::{runnables,inlay_hints} tests
#16256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Urhengulas
changed the title
ide::runnables testside::{runnables,inlay_hints} tests
Veykril
reviewed
Jan 4, 2024
| ignore: false, | ||
| }, | ||
| }, | ||
| cfg: Some( |
There was a problem hiding this comment.
This is interesting data (as long as its Some), same for when use_name_in_title is true. Would be good to render those conditionally (or otherwise keep them in the output in some way)
There was a problem hiding this comment.
Sure, gonna add that.
lnicola
approved these changes
Jan 5, 2024
Veykril
approved these changes
Jan 5, 2024
|
Thanks! |
|
☀️ Test successful - checks-actions |
14 tasks
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits the data being compared. Therefore the tests should be more readable, as well as being more robust to changes to the data structure.
Part of #14268.