Skip to content

minor: Mark remove_unnecessary_else as experimental #16750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 4, 2024

cc #16566 (comment) #16628

There seem to be some leftover issues with this, additionally its a style lint so it's not too nice to see for some people. We should flesh out our diagnostics stuff before adding more style lints I think

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2024
@Veykril
Copy link
Member Author

Veykril commented Mar 4, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 4, 2024

📌 Commit 6e802a0 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 4, 2024

⌛ Testing commit 6e802a0 with merge 00879b1...

@bors
Copy link
Contributor

bors commented Mar 4, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 00879b1 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 4, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 00879b1 to master...

@bors bors merged commit 00879b1 into rust-lang:master Mar 4, 2024
@bors
Copy link
Contributor

bors commented Mar 4, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@Veykril Veykril deleted the unnecessary-else branch March 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants